On Wed, 2 Jul 2008, James Carlson wrote: > Valerie Bubb Fenwick writes: >> On Fri, 27 Jun 2008, Will Fiveash wrote: >>> On Fri, Jun 27, 2008 at 09:46:11AM -0400, James Carlson wrote: >>>> For now, until the transition, leave them in place as they are, and do >>>> *NOT* build any code that relies on those strings. (Such code was >>>> almost invariably kludgey anyway.) >>>> >> >> Actually, Jim, our recommendation is to start removing them now. > > Actually, Valerie, you've misunderstood what I wrote. I'll try again.
Ah, got it. but then I think you misunderstood my response as well. I was not talking about removing ident strings for now. As a CRT I still enforce these are correct, and in fact I have updated the RTI Nits a few weeks back to make clear what is and is not acceptable at this exact moment: http://opensolaris.org/os/community/on/crt/rti-nits/ # SCCS Keywords * SCCS keywords, where used, must not be expanded in your source code. wx nits will verify this for you. * SCCS keywords must not be used as an interface for checking versioning or be output in any way, shape or form. This is required to help with our SCM migration project, which will be moving OpenSolaris based releases away from SCCS. Other options include maintaining the version number manually, leveraging hg tip in a Makefile after mercurial is live, or stop trying to track the version number in the driver and instead leverage existing information like the list of installed packages and mdb commands (::showrev -v and ::objects -v). * SCCS keywords, including %I%, must not be used outside file ident strings in Nevada. If you are modifying a file for Nevada that contains SCCS keywords outside an ident string, you are expected to remove them. I was talking about removing them when used in the modinfo version string. Several of us on the CRT have been working with many implementors on doing just this as were working right now. Mostly preventing new uses of such, but encouraging people to fix things now before they break :) [...] >> The SCM migration team will not be, to the best of my knowledge, fixing >> all of these instances themselves - that's why they filed bugs, to help >> share the load (and let the subject matter experts decide how they >> wanted to handle version strings going forward and fix any kludgey code) > > True, but returning to the original poster's question in this > particular case: existing and new files (until the Mercurial > transition) should be built with SCCS keywords strings. Using "wx" > will make sure that this happens. Hrm, I must've misread the original question, because I was pretty sure it was about one of those above mentioned version strings output to the user. > When we switch over, folks will type "hg nits" instead of "wx nits." > The copyright checks in the Mercurial tools have the opposite > assertion: they request that you yank out SCCS keywords strings, as > they're no longer meaningful for files integrated via Mercurial rather > than via Teamware. Cool - looking forward to using that. I am pretty sure you & I are saying the exact same thing. If what I have on the RTI-NITs (which was approved by several members of the SCM migration team, and put in at their request) is not correct, please let me know :) Valerie -- Valerie Fenwick, http://blogs.sun.com/bubbva Solaris Security Technologies, Developer, Sun Microsystems, Inc. 17 Network Circle, Menlo Park, CA, 94025. 650-786-0461
