My apologies.  I didn't look and see that the README.tools contained 
actual command examples with wildcard expansion, rather than a description 
of the exception_list* source files, which is in a different file anyway.

I'll fix that.

--Mark


On Wed, 9 Jul 2008, James Carlson wrote:

> Date: Wed, 09 Jul 2008 15:10:14 -0400
> From: James Carlson <James.D.Carlson at Sun.COM>
> To: Mark J. Nelson <Mark.J.Nelson at Sun.COM>
> Cc: scm-migration-dev at opensolaris.org
> Subject: Re: [scm-migration-dev] scm-migration tools code review followup
> 
> Mark J. Nelson writes:
>>
>> The changes in usr/src/tools/findunref/Makefile process multiple
>> exception_list* files (appropriately plural) into one exception_list,
>> which is then passed to the C version of findunref.
>
> Correct.
>
>> It works, I tested it.
>
> No dispute.
>
>>  There was some debate about why this belonged in
>> usr/src/tools/findunref, instead of a workspace-specific location, and
>> there was talk about modifying findunref.c to take multiple args.  I went
>> with this approach, explicitly, and thought that you (and others) were OK
>> with it.  That wasn't a "nobody seemed to object," it was more "I think
>> we actually discussed this, and ended up at this point."  That discussion
>> even involved explicit advice to "wx mv" the existing exception_list to
>> the new name (open, closed, teamware, mercurial, etc.) with the most
>> commonality.
>
> I'm not disputing it.  Please look at the README.tools file.  What
> you're saying IS NOT what that file says!
>
> --
> James Carlson, Solaris Networking              <james.d.carlson at sun.com>
> Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
> MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677
>

Reply via email to