Howdy--
As part of of the Mercurial aware tools putback, we changed this code:
451 echo "\n==== SCCS Noise ($LABEL) ====\n" >> $mail_msg_file
452
453 egrep 'sccs(check:| get)' $SRC/${INSTALLOG}.out >> $mail_msg_file
in nightly.sh to read as follows:
579 if [[ "$SCM_TYPE" = teamware ]]; then
580 echo "\n==== SCCS Noise ($LABEL) ====\n" >> $mail_msg_file
581 egrep 'sccs(check:| *get)' $SRC/${INSTALLOG}.out >> \
582 $mail_msg_file
583 fi
The pertinent change is on lines 453 (old) and 581 (new): two spaces in
the expression "sccs get" became zero-or-more spaces "sccs *get". Of
coures that should probably be a "+" to match "one or more," but that's
not the problem.
The problem is, the following sccs noise has been present in nightly logs
for years:
> ==== SCCS Noise (non-DEBUG) ====
>
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.11/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.10.1/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.10.1/sparc/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.10/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.10/sparc/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.11/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.10/sparc/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.10/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.10.1/sparc/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.10.1/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.11/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.10.1/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.10.1/sparc/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.10/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.8.4/5.10/sparc/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.11/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.10/sparc/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.10/x86/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.10.1/sparc/SCCS
> sccs get Sun/Solaris/PerlGcc/config/5.6.1/5.10.1/x86/SCCS
...but it has never been reported. The regular expression including two
spaces was part of the original integration of
6407796 "sccs get" rule considered harmful
into snv_39. As nearly as I can tell, it's wrong, and should have always
been one (or possibly "one or more") spaces.
So now we're three weeks away from Mercurial, and I need direction from
the ON NV core team. Do I:
1. Leave it the way it is, allowing SCCS Noise into nightly mail_msgs,
knowing that we're about to get rid of Teamware usage anyway.
2. Turn SCCS Noise into a transient, such that it only appears in mail_msg
when it changes.
3. Revert the regular expression, knowing that it won't catch valid SCCS
noise.
4. Fix the regular expression, leaving us still needing to decide between
options 1 and 2 above.
5. Something else?
--Mark
