For the record, I looked at this and had one question, which I think Rich incorporated, and now I'm happy.
--Mark On Tue, 15 Jul 2008, Richard Lowe wrote: > Date: Tue, 15 Jul 2008 21:29:19 -0400 > From: Richard Lowe <richlowe at richlowe.net> > To: scm-migration-dev at opensolaris.org > Subject: [scm-migration-dev] Please review 6560958 > > > Please review: > 6560958 Solaris:: perl modules should not use SCCS keywords in version > information > > Webrev: > http://cr.opensolaris.org/~richlowe/onnv_6560958 > > %I% is used within the Sun::Solaris:: perl modules as part of > providing versioning between the perl (.pm) and C (.xs -> .so) parts > of a perl module. These uses aren't frivolous, they're library > versioning and should thus be maintained. > > The same symbol ($VERSION) is also used when creating tarballs for > CPAN with 'make tardist'. > > The fix has been to expand said keywords when used for that purpose, > retaining their value as that of the newest SCCS delta. > > I have built perl, run the test suites for those modules that have > them (with the exception of Exacct, I'm still trying to figure out why > its test suite refuses to run (with or without changes)). > > I have run wsdiff between a proto area from prior to these changes, > and my current proto area, which only shows expected differences, > (CDDL, #ident removal, %I% -> version). > > I have run wsdiff between /usr/perl5 on my system (snv_93), and my > proto area, which only shows expected differences. (CDDL, #ident > removal, lack of .SUNW_signature in my objects). > > I have removed #ident lines in these files, as they will be > integrating to Mercurial (onnv-transition, then the mercurial > onnv-gate). They should never enter TeamWare. > > I have only changed the copyrights on files with material changes (not > just ident expansion). If we're going to have to bump the copyrights > anyway, I would prefer to do so now, so call out if you'd prefer I do > that. > > Thanks, > > -- Rich > _______________________________________________ > scm-migration-dev mailing list > scm-migration-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev >
