Looks good On Mon, 21 Jul 2008, Richard Lowe wrote:
> Date: Mon, 21 Jul 2008 20:32:39 -0400 > From: Richard Lowe <richlowe at richlowe.net> > To: scm-migration-dev at opensolaris.org > Subject: [scm-migration-dev] Please review #548 > > > Please review: > #548 hg-active should catch mercurial.util.Abort > > Webrev: > http://cr.opensolaris.org/~richlowe/onnv_548 > > Simple change, obvious results. > > I chose to only catch Abort, which mercurial tends to use to signal > such errors, rather than a greater range of things which hg(1) would > catch as, for our purposes, many of the others (EnvironmentError, for > instance), are things for which I would prefer a backtrace. (in the > context of webrev, and thus hg-active, I think most represent graver > issues). Opinion welcome. > > I tested this in the obvious case via: > > hg-active -w . -p path/to/cadtest > > Which will abort as they are unrelated, and with this change output: > > Abort: repository is unrelated > > and exit indicating failure > > Thanks, > > -- Rich > _______________________________________________ > scm-migration-dev mailing list > scm-migration-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev >
