Dean Roehrich writes: > On a side note: I'm concerned about the cstyle hook with respect to FOSS > software. If ON is going to take on FOSS software, then we shouldn't be > messing with the cstyle of that stuff anyway. The style of that code needs to > match the upstream version, else it's just that much more difficult to > maintain.
Don't be concerned. ;-} We already have a *lot* of FOSS stuff in ON. We have for decades now. It's not at all new or an unknown issue to the gatekeepers. It's a gate policy to check cstyle on putback (push) to the gate, but files that are designated by the developer in his RTI as needing to be unclean in order to be kept in sync with some other repository are excepted from that requirement. There are similar issues for lint, copyright notices, and other policies. In other words, the hook should run, and it could/may usefully print an "are you sure?" message back to the invoker, but lack of cstyle- goodness should never block, and the main purpose is to prod the gatekeeper into making sure it's right. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
