Hi guys -

Thanks so much for your help!

I'll be sending the new page out for review, hopefully later this afternoon.

On Tue, 22 Jul 2008, Richard Lowe wrote:

> "Mark J. Nelson" <Mark.J.Nelson at Sun.COM> writes:
>
>> Section on SCCS Keywords should be rewritten as follows:
>>
>> SCCS Keywords
>> - ident usage (whether #pragma, ident, or .ident) should be cleaned up
>>    incrementally.  If you touch a file, you should remove these strings.
>>    The hg keywords (part of hg nits and hg pbchk) command should correctly
>>    complain about this.  So look for clean hg keywords output.
>> - Any other usage SHOULD have been cleaned up prior to the Mercurial
>>    transition, but it's possible that some was missed.  For this, please
>>    advise the developer to remove the usage entirely.  If that is an
>>    unacceptable answer, and you deem the usage to be an interface, the
>>    keywords may be replaced with their static expansion (or incremented
>>    therefrom), or the user may use "hg id" or "hg log" output for
>>    version information.  The hg id command refers to the entire repository,
>>    while the hg log command refers to a file or set of files.
>>
>> Under paperwork items:
>> - s/or sccs diffs -C/hg [p]diff -u/
>
> pdiff doesn't take -u, it's always unified.

Cool. thanks!

>> - s/webrev and sccs diffs/webrev and hg [p]diff/
>>
>> Non-Mercurial-related:
>> - Pattie Levinson is not currently the manpage contact for the c-team, you
>>    should get a current name from Miguel.

This is fixed .

>> General:
>> - s/putback -n/hg outgoing -v/g
>> - s/workspace/repository/g
>
> Didn't we come up with something better than outgoing -v?

I'm using "outgoing -v" in the doc now - is there something better?

>
>> The "other more general nits" should read as follows:
>> - No bug IDs in the source code; the Mercurial changeset descriptions
>>    cover that.
>> - There should be no merge changesets; hg mergechk output should be
>> clean.
>
> mergechk is not a separate command, it is only part of pbchk

Cool, thanks!


Valerie
-- 
Valerie Fenwick, http://blogs.sun.com/bubbva
Solaris Security Technologies,  Developer, Sun Microsystems, Inc.
17 Network Circle, Menlo Park, CA, 94025.

Reply via email to