Mark J. Nelson wrote:
> External folks may stop reading now, this won't be interesting.

Nah, it'll be interesting... and tantalizing ;)

> I propagated the following fixes:
> 
> 286 deleted_files needs to be deleted post-migration
> 444 building inside an ON repository overwhelms hgignore mechanism
> 4758439 some files use "current date" sccs keywords
> 
> into a closed repository.
> 
> For 286: I mercifully pulled these files from the active list for the 
> webrev.  Instead, I'll just tell you: I did an "hg rm deleted_files" from 
> the root of the closed repo.
> 
> For 444: I made the identical change (added .hgignore to repo  root) as 
> was done in the open repo.
> 
> For 4758439:
> - I removed ident lines from files that I was touching, but (obviously)
>    not from others.  The only keywords I didn't completely whack were for
>    use by the SCSI_FAILOVER_OPS() macro; these I simply replaced with their
>    static expansion.

You should get Chris Horne to check the scsi_vhci fops changes.

> - The scope was relatively small, so I did more than just "current date."
>    I actually cleaned up all of the non-ident SCCS keywords in the closed
>    tree.  Please let me know if this should have an additional bug
>    associated with it because of that.
> 
> Anyway, here's the webrev:
> 
> http://anthrax.central/net/mrliberal/export/ws/mjnelson/mercurial-push/usr/closed/webrev.closed-repo/
> 
> Note that "code review" in this case will not be followed by a push, other 
> than the first-thing-into-the-new-gate next week.

Apart from the above, looks fine to me.


James C. McPherson
--
Senior Kernel Software Engineer, Solaris
Sun Microsystems
http://blogs.sun.com/jmcp       http://www.jmcp.homeunix.com/blog

Reply via email to