http://bugs.grommit.com/show_bug.cgi?id=423

           Summary: questionable format for rename-only changes in hg webrev
           Product: SCM Migration
           Version: unspecified
          Platform: All
        OS/Version: Solaris 11/Nevada
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: webrev
        AssignedTo: scm-migration-dev at opensolaris.org
        ReportedBy: mike.kupfer at sun.com


Jim Carlson recently posted a Mercurial-based webrev where a couple
files were moved to deleted_files, without any contents changes.  The
links for the files looked like this:


------ ------ ------ ------ ------ --- New Patch Raw

The line looked wrong to me.  Since there were no changes to the file
contents, I could see suppressing the diffs links, but it seemed like
there should be an Old link.

OTOH, this is the same as what "wx webrev" generates when a file is
moved in a Teamware workspace, so I'm not sure why Jim's webrev looked
wrong to me when "wx webrev" output does not.

One possibility is that for a Teamware workspace, wx will use this
text for the comments:

    Renamed only (webrev comment generated by  wx, not an sccs
    comment)

Our webrev does not add any text, which is probably the desired
behavior (because unlike wx renames, hg renames will have commit log
text associated with them).

Another possibility is that wx puts rename-only changes at the bottom
of the page.  For Jim's webrev, the renames were at the top.

A third possibility is that it's just been too long since I looked at
a rename in a Teamware-based webrev.


-- 
Configure bugmail: http://bugs.grommit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to