Mark J. Nelson wrote: > >> Please review: >> 421 webrev: clean up global vars vs. function params >> http://cr.opensolaris.org/~nbush/scm-migration/421/webrev/ > > It seems like you should either remove all of the typeset declarations > from build_old_new, or from each of the build_old_new_blah functions > that it calls. But you never reference them in build_old_new, so it > seems like the only use of those typesets is to be inherited by the > called functions, and you're explicitly redefining them in each place. > My preference, I think, would be for build_old_new to be the single > point where these are defined; then you don't even end up passing args > at all to build_old_new_blah, but each such function gets a well defined > set of parameters. > > Instead of moving the olddir/newdir mkdir statements outside of the > loop, why not just remove them entirely? The semantics of mkdir -p will > cause them to be created implicitly by the mkdir statements inside the > loop already.
I agree with your suggestions. Here's a new webrev; please note the new URL: http://cr.opensolaris.org/~nbush/scm-migration/421/webrev.v2/ --Nathan
