Overall it looks good. A couple things caught my eye:
* common_files/i.devlinktab_sparc
There's
139 cp /tmp/d.$$ $dest
but you've taken out the rm of /tmp/d.$$. Should that "cp" be "mv"?
* common_files/i.etcsystem:
Having i.etcsystem know /etc/system's most recent SCCS delta seems
awfully fragile. And even if it doesn't actually need to know the
exact revision string (which I'm not sure it does), the new code
implies that it does, which will be confusing. Maybe we should just
change the revision check to something like
193 if [ "$oldrev" != "$newrev" -o -z "$newrev" ]
?
* common_files/i.publickey
Some comments for the nawk script would be helpful. Something like
# From the source file, take everything before the "nobody"
# line. If there's no "nobody" line, take the entire thing.
#
# From the destination file, take everything after the initial
# comment block. Or, if there's a "netname" comment, take
# everything after that comment.
A note motivating the "netname" test would be useful, too. Is it an
attempt to preserve user comments?
cheers,
mike
