Richard Lowe writes: > I was initially against us supporting -u/-d (and I still am against > -d, so we still don't),
What's the argument against overriding the date code? The argument for it would be symmetry (or parity) with the existing 'commit' options. > but the bug makes a fairly compelling case in > -u allowing a sponsor to force the user information to the real > author after a merge or the like. The change seems fine to me. One question, though. In the invocation of the squishdeltas() method in cdm.py (line 915), you use a mix of position-dependent and keyworded argument types. It seems odd to me, but maybe this is just normal Python and I should try to look away. ;-} -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
