Jim Carlson asked me to review what I could of the big webrev at:
http://cr.opensolaris.org/~kupfer/onnv-scm/
This is my initial batch of comments, focussing on changes to existing
scripts in reverse alphabetical order..
usr/src/tools/scripts/xref.sh:
WES-1 detect_scm(): shouldn't this be in some sort of common code?
rather than cut & pasted and separately maintained?
WES-2 detect_scm() logic: for a hypothetical broken workspace where
both .hg and Codemgr_wsdata exist, should the presence of "workspace"
in the path determine whether to prefer hg over teamware?
WES-3 Should we set CODEMGR_WS in the non-teamware case?
usr/src/tools/scripts/wx.sh:
WES-4 I'm a little confused about why lines other than 4417-4424 (the
code which disables wx if hg finds a root) are part of this
wad.
WES-5 Is it possible that this will trigger a false positive if you
run "hg init" in a parent directory of a teamware workspace?
Where do we document these limitations?
usr/src/tools/scripts/ws.sh:
WES-6 As with WES-1: we seem to have more open-coded SCM system
detection which is *different* from that found in xref.sh
WES-7 line 371: I think you mean "SunOS 5.x-specific" since 5.0 is
long gone.
WES-8 Lines 376-408: I suspect a "uname -s" check is also in order.
usr/src/tools/scripts/webrev.sh
WES-9 Lines 1150 "comments_from_wx" seems wrong for mercurial if
wx commits suicide if mercurial is in use.
WES-10 Lines 1469-1497: yet another "detect_scm"!!
WES-11 Lines 2435-2448: doesn't hg have a different way of recording the
committer's name in .hgrc ? Shouldn't we use that if available?
usr/src/tools/scripts/sdrop.sh
WES-12 Lines 55-57: yet another detect_scm fragment which doesn't use "hg root"
but instead checks for .hg ??
(and, uh, $CODEMGR_WS/.hg ??!?!?)
usr/src/tools/scripts/nightly.sh
WES-13 I thought bringovercheck was going to be nuked as part of this wad.
usr/src/tools/Makefile.tools:
WES-14 Lines 66-73: might INS.pyfile belong in Makefile.master (we're going to
have python elsewhere in ON at some point, right?)
