Mark J. Nelson writes:
> http://anthrax.central/net/mrliberal/export/ws/mjnelson/onnv-transition-dev/webrev.transition/
[...]
> I need review of the "interesting stuff" and "6729074" links, and I would
> be thrilled if somebody besides me took the time to wade through the rest.
Despite the clear warnings otherwise, I went through all of it. ;-}
In general, the CRs and other bug entries need evaluations and the
other usual attributes. They're mostly stuck in "Accepted" state or
something like that.
In the Python code, I did what I could, but I'm no Python expert. The
one thing that jumped out at me was the funky spelling of 'honour'.
(Just a nit, but the tradition in at least ON [and probably other
consolidations as well] is to use American English spellings rather
than "International" English. If this were user-visible, I'd call it
a bug rather than just a nit.)
For 444 (.hgignore), the fix (apparently just ignoring everything)
doesn't seem to match the description in the bug report itself.
For the .java files, do the "@version" things matter in any way for
javadoc? If they weren't important, then just stripping them seems
good. Otherwise, we might need some other fix. (I'm asking because
[a] I'm no java expert and [b] CR 4758439 is still in 'Accepted' state
and doesn't have an Evaluation.)
For pkgdefs/SUNW{mibii,sacom,sasnm}/pkginfo.tmpl, the PSTAMP entry was
entirely removed. This is usually commented out like so:
#PSTAMP="<developer defined>"
I'm guessing that it doesn't actually matter, but I'm not sure what's
done with this upstream during WOS construction. (I looked at
SUNWmibii in the delivered product, and pkginfo there has the swilly
string, so this will make an observable change. Probably for the
better, but may need to be at least disclosed in the CR.)
For tools/codereview/codereview.1, and as long as you're changing this
anyway, I suggest fixing line 22 to look more like the other headers.
In other words:
.TH codereview 1 "10 June 2005"
... lower-case name, section 1 (not fictitious "1-LOCAL"), and spelled
out date rather than funky SCCS reversed date.
A similar comment applies to the change in tools/scripts/acr.1:22.
tools/cw/cw.c:1864: if this "-_versions" thing is needed at all, then
I recommend making that version string a #define, and defining it near
the top of the file along with a block comment. If it's useful, then
it'll need to be updated each time someone modifies the file, and
burying it in the code makes it unlikely that'll happen.
tools/env/opensolaris.sh:82: the "//hg" here doesn't look right to me.
All of my working paths to hg.opensolaris.org use a relative reference
to "hg/onnv/onnv-gate" and not an absolute path. Is this right?
tools/scripts/wx.sh:28-29: these can probably go now as well.
I don't see how the change in tools/onbld/Scm/Backup.py is related to
bug ID 303.
I like that some of the things you nuked were old, broken, expanded
SCCS keywords in the SLP code. ;-}
--
James Carlson, Solaris Networking <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
