Vladimir Kotal writes: > Vladimir Marek wrote: > > <snip> > > > That's true. But you don't need to recommit all the time. Just before > > final putback should be fine. If you commit often in your workspace, it > > You missed my point - I need to recommit after each code review > iteration for webrev refreshment since generally code reviewers are not > too happy seeing bogus commit messages in a webrev.
Unless the result of the commits is just an unholy mess, I suggest telling your code reviewers something like this: "The code is complete, but I haven't done recommit yet in this workspace. I'll do that shortly before integration." Note that Mercurial in ON pretty much requires a sync and recommit as you're nearing final approach to a push, so there's just no way that the bits your reviewers see will be unmolested by recommit before push. They're going to have to trust you anyway. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
