Hey all,
Please review:
6738460 comments check is incorrect, possibly due to pipe symbols
in the synopsis
Webrev:
http://cr.opensolaris.org/~richlowe/onnv_6738460/
I'd appreciate people paying close attention, while reviewing, to the
rationale contained in Evaluation (below), regarding free-form fields.
I recall Mike telling me that one or two others we request are
free-form but unlikely to contain a |. That should be confirmed (or
someone should refresh my memory as to which fields, so I can cease
requesting them, if they are unnecessary).
Evaluation:
We request |-separated output from Monaco when requesting CR
information, while not sufficiently guarding embedded |'s within a
field.
Further, Monaco does not escape literal |'s within a field.
So we must ask for free-form fields last, and explicitly specify
how many field separators we expect to see. This is, obviously,
only robust to one field that may contain a |.
I don't particularly like this, but I think a quick fix to allow
people to continue working, followed by someone with access to
Monaco making a more appropriate fix (requesting results in a
different format, perhaps?) would be the better thing for us to do.
Testing:
jmcp ran a modified tooltest on SWAN for me, and with the changes
to DbLookups, above, it passed.
However, I since adjusted the test case used to be an older bug,
rather than this bug with its prior synopsis, such that this bug
could have synopsis altered (and thus be integratable).
It has not been re-run with this test case.
pbchk:
pbchk: Errors with mis-matched synopsis in both cases (because
b.o.o hasn't caught up).
Thanks,
-- Rich
