as yet a still unfiled bug, but it's essentially the one Rich, Forrest, and I have iterated on: having HdrChk check the #ident line only if it exists. If it exists, then the wx keywords check will check its actual format.
This way Teamware/wx will continue to check it, but use within Mercurial will only check to see if it's present or not. If it is (in unexpanded form), then our SCCS keywords will fail it. http://cr.opensolaris.org/~stevel/onnv-scm.hdrchk/ There's also a minor fix for 332 in there. Two things I'd like opinions on: 1) Copyright. onnv-gate's hdrchk.pl throws a "Missing copyright in opening comment" message for files like /usr/include/sys/firefox/gtkxtbin/gtk2xtbin.h. Our HdrChk doesn't. This is because we treat all opening comments as one block; also we have the separate Copyright check to check for these sorts of things (so we wouldn't throw the missing copyright error twice) What do people think? 2) We throw a "Header guard does not match filename" on a header guard that looks like: __FOO_H__ (for foo.h) or other things that don't strictly match _FOO_H_ Is this the best error message? Intuitively, I would think it should be "Invalid or missing header guard" myself - but this is the same behaviour as the gate's hdrchk.pl, so I'm curious what other people think. cheers, steve -- stephen lau // stevel at sun.com | 650.786.0845 | http://whacked.net opensolaris // solaris kernel development
