Stephen Lau wrote: > Forrest Wu wrote: >> Stephen Lau ??: >>> Forrest Wu wrote: >>> >>>> Hi steve, >>>> >>>> I am a little bit confusion with this. For TeamWare, how HdrChk.py catch >>>> a file without #ident error? On the other hand, for Mercurial, how >>>> HdrChk.py catch a file with #ident error? Because of HdrChk.py doesn't >>>> know what is the game role for the given file. >>>> >>> For Teamware, a file without #ident will be caught by the >>> usr/src/tools/scripts/keywords.sh check (as run by 'wx keywords' or pbchk) >>> >>> For Mercurial, a file with #ident AND SCCS keywords will be caught by >>> our Keywords check (usr/src/tools/onbld/Checks/Keywords.py) as invoked >>> by Cadmium's 'keywords' or 'pbchk'. >>> >>> So the trick isn't in HdrChk.py, it's in the fact that different >>> keywords checks (tools/scripts/keywords.sh vs. >>> tools/onbld/Checks/Keywords.py) are invoked by different SCM tools (wx >>> vs. hg/cdm). >>> >> Make sense. >> One issue I notice is line #64 in scripts/hdrchk.py. ?-a' will never >> become effective, due to lenient was not passed in function hdrchk(). > > Ah, good catch. Thanks. I've filed 338 for that. >
Webrev has been updated. If there are no objections from anyone by today I intend to push it. Speak now or forever hold yer peace. ;) cheers, steve -- stephen lau // stevel at sun.com | 650.786.0845 | http://whacked.net opensolaris // solaris kernel development
