Mike Kupfer wrote: > I'd like to get a formal review of > > 6609947 nightly: findunref, then sdrop
Mike, I have three comments: 1) Why move the mktpl step at all? It seems that it was already happening before findunref. The new location introduces two consecutive if-statements (lines 2130, 2147) that have the same conditional expression. They might as well be run together into one if-statement. 2) This is minor, but w.r.t. the lines: 2639 echo "\n==== Generating OpenSolaris tarballs ====\n" | \ 2640 tee -a $LOGFILE >> $mail_msg_file Most of the rest of the script has the "tee" command written as "tee -a $mail_msg_file >> $LOGFILE". Unless it matters here it might as well be made to match. 3) In lines 2683-2708, it looks like the order of sdrop and bfudrop were reversed relative to each other vs. the original version. If I followed the bug comments correctly, these two steps do not interact. Is there another reason for this switch? --Nathan
