http://bugs.grommit.com/show_bug.cgi?id=369





------- Comment #7 from mike.kupfer at sun.com  2007-10-30 16:12 PDT -------
Okay, that helped a lot.  Thanks.

My first inclination is to just use ui.write() everywhere, so that -q
is more or less a no-op.  That helps clarify the check output, and
it's comparable to what wx gives you.

My second choice would be for -q to only suppress the sections headers
for which there is no output.  In your example, this would be at least
"CDDL block check", "copyright check", "C style check", "Java style
check", and "uncommitted changes" (NB: "uncommitted" has 2 m's :-)).
For the skipped checks ("RTI checks" in your example), I lean towards
printing them, but I could go either way.  From my limited
understanding of the ui code, we could do this by pushing a buffer (or
two) and then deciding at the end whether to print anything.

My last choice would be to maintain the -q behavior, but for each
check, format the -q output in a way that it can be understood by an
expert without the section headers.  (That is, the expert can tell
just by looking at the message what section is belongs in.)  And add
some amount of comments so that (a) we remember next time that this was
deliberate, and (b) anyone who changes the check output will know that
it has to be self-sufficient in quiet mode.

The last choice seems like a whole lot of work for slight gain,
which is why it's my last choice.


-- 
Configure bugmail: http://bugs.grommit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to