Stephen Lau wrote:
> http://cr.opensolaris.org/~stevel/hg_branch/

As a random aside, I keep entirely forgetting that that exists.

> Anyone want to take a look at the above and see if it makes sense?
> 
> This uses hg-active (and by extension Cadmium) to determine the 
> parenttip to determine what to diff against.  The previous behaviour was 
> depending on 'hg log <path>' to follow the branch, but it doesn't (and 
> adding -f doesn't help since apparently for files, that only follows 
> copies/renames - not branches).
> 
> In any case, I haven't filed a bug to track it yet - but if the changes 
> look reasonable I will.

webrev.sh:
   What happens if we get a file list without HG_PARENT?  This needs to
   continue to work with explicit file lists of both varieties (though it may
   not work as well...)

webrev.sh:1464
    You set hg_parent (note the case), and never use it. g
    Given that, this whole bit doesn't seem to have a purpose (does it?)

webrev.sh:1585
    hg cat exits with 0 even when it fails, this won't work.  (but this
    annoys me, so fixing hg would also be ok by me...)

webrev.sh:1943
    tip is almost always the wrong thing to use in a world with in-repo
    branches, consider 'hg parent'

-- Rich

Reply via email to