I'd be grateful if a handful of people would carefully review:
  #333 - cdm managed to turn a rename into a copy

The webrev is available at http://cr.opensolaris.org/~richlowe/scm_333

This is the change to make recommit work in terms of git-formatted
diffs, rather than via a forced commit on top of an unnatural parent
node.

This more closely matches how you'd do this, should you be doing it by
hand, and makes handling of renames and copies much more sensible. 

The meat of the change is to WorkSpace, the change to cdm is mostly a
hook to mean the tests I have can take both paths through there (make
sure it fails if the user says no, make sure it works if they say yes). 

I'd especially like people to look carefully at the file handling and
error handling and recovery, and generally look at it very closely.

I'd also appreciate it if people were to apply the diff (should apply
to current tip), and cautiously make use of it, with either real or
contrived workspaces.  The emphasis, of course, being on *carefully*.

Thanks,

-- Rich

Reply via email to