Generally looks good. Issues that I noticed are
- cdm_branchchk(): wrap the "Workspace has named branches" message (a la
bug #405)?
- cdm_branchchk(): ui.warn -> ui.write in loop to print named branches
- The buffer management in run_checks() strikes me as a bit contorted.
Correct, but likely to throw someone in the future. I think it would
be simpler to always push a buffer, and then do something like
if result != 0 or not ws.ui.quiet:
ws.ui.write(output, '\n')
- in cdm_pbchk(), if there are any guidelines about the order that the
checks are done in, it would be good to write them down in the
comments.
mike
