Forrest Wu wrote:
>
> Stephen Lau wrote:
>> Forrest Wu wrote:
>>> Stephen Lau wrote:
>>>> Hi Forrest,
>>>> digging up a really old thread here. :) Did you ever integrate
>>>> this into the onnv-scm tree?
>>>>
>>> No. I haven't put it back. Don't know if you accept my solution on
>>> this.
>>
>> Could you point me at your latest webrev and I'll take another look?
>>
>> cheers,
>> steve
>>
> Hi Stephen,
>
> Here is the latest hdrchk modification for HdrChk.py to support both
> TeamWare and Mercurial. I also modify the relevant test case and test
> example to verify those change. Please give me your comments and
> suggestion.
>
> http://tas.eng/export/pub/Forrest/zfs/scm/scm_stool_2/webrev/
>
> 1> Modify interface of function hdrchk to support both Teamware and
> Mercurial.
> 2> Update Checks/HdrChk.py.
> 3> Currently, there is a bug in hdrchk.py. 'hdrchk -a' doesn't work as
> we expected. Fixed it.
> 4> Add a set of header check test examples, m-hdrchk, for mercurial.
> 5> Rename hdrchk to t-hdrchk to keep the test examples for teamware.
> 6> Modify test_hdrchk.py to support both Teamware and Mercurial.
> 7> Add hdrchk2.py for Mercurial. So, wx will use hdrchk and Mercurial
> use hdrchk2
>
Hi Forrest,
Sorry for the late reply. I'm not keen on making an almost duplicate
hdrchk2.py from hdrchk.py and relying on passing noident around. I
thought we had discussed having hdrchk only validate #ident if one
existed rather than conditionalising based on which SCM it gets called from?
Let me know if I'm not making any sense :) and I can take your wad and
make changes from there.
cheers,
steve
--
stephen lau // stevel at sun.com | 650.786.0845 | http://whacked.net
opensolaris // solaris kernel development
