On Mon, Mar 30, 2009 at 10:10:21PM -0400, Richard Lowe wrote:

> Danek Duvall <danek.duvall at sun.com> writes:
> 
> > While I think that you should go back and "hg mv" the files, I'll note that
> > webrev doesn't do the right thing here -- it will see the file as being
> > added and then removed, rather than moved.
> 
> If that's what actually happened, that is the right thing, isn't it?
> 
> Can you give me more detail about that bit?  (I'm so easily confused...)

It would be really nice if you "hg mv"ed a file, then edited it, to be told
that it was moved, and the following changes made, rather than having one
diff that showed an entire file disappearing and another diff that showed
an entire (slightly different, but it won't tell you what those differences
are) file appearing somewhere else.

Of course, you want to be told that the file was moved or copied, and where
from, but you probably also want to review the changes that were made,
rather than having to download the two raw files and run diff on them
yourself.

Danek

Reply via email to