Nathan Bush <nathan.bush at sun.com> writes: > Richard Lowe wrote: >> Nathan Bush <nathan.bush at sun.com> writes: >> >>> Hi, >>> >>> I need a code review for: >>> 423 questionable format for rename-only changes in hg webrev >>> >>> The change to webrev is: >>> http://cr.opensolaris.org/~nbush/scm-migration/423/webrev/ >>> >> >> The only thing that jumps out is a nit I don't really mind either way: >> >> 2584: -n is perhaps better than ! -z >> >> The results also look ok, to me. >> >> -- Rich > > Good point, there were a lot of double-negatives in there. > > I respun the webrevs, the new URLs are: > http://cr.opensolaris.org/~nbush/scm-migration/423/webrev.v2/ > http://cr.opensolaris.org/~nbush/scm-migration/423/sample.v2/ >
Looks fine to me. -- Rich
