http://bugs.grommit.com/show_bug.cgi?id=446

           Summary: webrev creates inconsistent HTML document titles
           Product: SCM Migration
           Version: unspecified
          Platform: All
        OS/Version: Solaris 11/Nevada
            Status: NEW
          Severity: normal
          Priority: P4
         Component: webrev
        AssignedTo: scm-migration-dev at opensolaris.org
        ReportedBy: nathan.bush at sun.com


In general, webrev will create HTML document titles in the form:
"repo_name DiffType somepath/somedir"

For example: "onnv-scm Cdiff usr/src/tools/scripts/webrev.sh"

I have noticed some possible inconsistencies, as follows:

1) For each of the types {Cdiff,Udiff,Wdiff,Frames} and when
   the file being displayed exists in the root of the repository,
   it is listed in the document title as "./somefile" even though
   it is simply listed as "somefile" on the index page.  The leading
   "./" could be omitted here.

2) For "Sdiff" windows, the final file name is not displayed; only
   the intermediate directories (if any) are shown:
   "repo_name Sdiff somepath" or "repo_name Sdiff ."

3) When a file has been renamed, the "Old" link will have a title
   that uses the new name.  For example, if "olddir/oldfile" is
   renamed to "newdir/newfile", the title of the page after the
   "Old" link would be "Old newdir/newfile".  This might be clearer
   if the "Old" link also used the old filename: "Old olddir/oldfile".

In my opinion,
1) is only a cosmetic issue
2) is clearly a bug
3) seems wrong to me, but may also be a matter of opinion

I would definitely like to fix #2.  I am curious about how others feel
about #1 and #3.


-- 
Configure bugmail: http://bugs.grommit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to