Revised webrev: http://cr.opensolaris.org/~nbush/scm-migration/446/webrev.v2/
The changes from v1 to v2 are: 478c478 < print "<title>$WNAME Sdiff $TPATH/$TNAME </title>" --- > print "<title>$WNAME Sdiff $TPATH/$TNAME</title>" 2386c2386 < source_to_html Old $P < $ofile > $WDIR/$DIR/$F-.html --- > source_to_html Old $PP < $ofile > $WDIR/$DIR/$F-.html --Nathan Nathan Bush wrote: > #3 is also a simple change, only one character: $P vs $PP. > > The reason I say it is a matter of opinion is that there is a good > argument for either form. > > If the window is titled as it is currently, it would say: "repo_name > Old newdir/newfile". This can be interpreted as "This is the old > version of the file that now exists in the changed workspace as > newdir/newfile." All of the other links refer to files in terms of > their names in the changed workspace, and this also matches the name > that appears in bold in the index page. > > If it were changed, to "repo_name Old olddir/oldfile", that could > be interpreted simply as: "This is the file olddir/oldfile from the > old version of the workspace". > > It sounds like we're both leaning in favor of this change. > > --Nathan > > > Mark J. Nelson wrote: >> I could take or leave fixing the leading "./" for files in the root >> directory. >> >> But why not fix #3? >> >> --Mark >> >> >> >> On Tue, 11 Mar 2008, Nathan Bush wrote: >> >>> Date: Tue, 11 Mar 2008 22:42:43 -0700 >>> From: Nathan Bush <Nathan.Bush at Sun.COM> >>> To: scm-migration-dev at opensolaris.org >>> Subject: [scm-migration-dev] Please review # 446 >>> >>> Hi, >>> >>> Please review: >>> 446 webrev creates inconsistent HTML document titles >>> http://cr.opensolaris.org/~nbush/scm-migration/446/webrev/ >>> >>> You can see the fix in action in the above webrev itself. >>> >>> Thanks, >>> >>> --Nathan >>> _______________________________________________ >>> scm-migration-dev mailing list >>> scm-migration-dev at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev >>> >> _______________________________________________ >> scm-migration-dev mailing list >> scm-migration-dev at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev > > _______________________________________________ > scm-migration-dev mailing list > scm-migration-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev
