Nathan Bush <nathan.bush at sun.com> writes:

> Rich (since we discussed this one already) or anyone else, please review:
>
> 448 webrev should use Hg's ui.username property to identify preparer
> http://cr.opensolaris.org/~nbush/scm-migration/448/webrev/

Perhaps it would be better to use html_quote on the result, rather
than duplicating 2/3rds of it? (< and >, but not &).

Beyond that, it looks ok to me.

>From what I can tell, the behaviour of showconfig in this case would
be correct, it will use the settings as found in order, ignoring
untrusted hgrc files, so the setting in the workspace would be used
first as long as you trust that hgrc.

(that's partly a note to myself, since I was somewhat wondering about
that).

-- Rich

Reply via email to