DbLookups.py:34
This is plain wrong, we ask opensolaris.org, not sac.eng
DbLookups.py:51
We define this here, but use it way down in BooBug (the only place
we use it), should not be global, should be closer to its use.
DbLookups.py:79
Monaco and BooBug do things very differently (partly out of
necessity), but it would be easier to paper over in BugDB if they
weren't so grossly different.
(I'd prefer not returning the dict of dicts in either, too, but I could go
easier on that...)
DbLookups.py:379
Huh?
Rti.py:58:
Oh there, not really "below". (see dblookups 379)
Rti.py:88
Does this mean we ask webRTI for the same RTI N times, if that RTI
contains all N bugs in our comments? Surely there's no need?
(or does the code in DbLookups.Rti really suggest it doesn't list
all CRs under that RTI, when queried that way?)
Rti.py:94
I'm pretty sure that if we get RtiOffSwan here, we should fail
entirely, with a single message. That would be the last bit of what
I meant in #370 (it does now tell me that I need SWAN access, rather
than that my RTI doesn't exist, but only telling me once would be
nice).
% rtichk 8675309 8675309 8675309 8675309 8675309
RTI status checks need SWAN access: 8675309
RTI status checks need SWAN access: 8675309
RTI status checks need SWAN access: 8675309
RTI status checks need SWAN access: 8675309
RTI status checks need SWAN access: 8675309
If the first fails, the last 4 will too, why try?
It should also make sure that each of the bugids listed
isdigit()
There are various XXX comments, all should be dealt with (removed,
fixed, etc). There's also various comments that say more about work
in progress than the code.
It'd be great to get docstrings or some other form of useful
documentation in there too, as appropriate.
This is just a quick pass through both, if anyone wants to deal with
these it'd be great if they took a more careful pass through them at
the same time. It also should be pretty easy for anyone who feels
like it to do it.
(I haven't filed bugs, because I'm not certain if one big bug, or
several bugs would be preferable, I'll leave that up to whoever picks
this up).
-- Rich
