http://bugs.grommit.com/show_bug.cgi?id=456
Summary: DbLookups nits
Product: SCM Migration
Version: unspecified
Platform: All
OS/Version: Solaris 11/Nevada
Status: NEW
Severity: normal
Priority: P3
Component: onnv-scm
AssignedTo: scm-migration-dev at opensolaris.org
ReportedBy: richlowe at richlowe.net
DbLookups.py:34
This is plain wrong, we ask opensolaris.org, not sac.eng
DbLookups.py:51
We define this here, but use it way down in BooBug (the only place
we use it), should not be global, should be closer to its use.
DbLookups.py:79
Monaco and BooBug do things very differently (partly out of
necessity), but it would be easier to paper over in BugDB if they
weren't so grossly different.
(I'd prefer not returning the dict of dicts in either, too, but I could go
easier on that...)
DbLookups.py:379
This comment actually refers to Rti.py:58, both comments could be clearer
(especially in their relation to eachother)
DbLookups.py:198
Fix the problem the XXX comment refers to, or remove said comment.
(the comment refers to bug #140)
It would be great if we had docstrings as appropriate (in a few cases there's
comments that could be used already there). It would be a good idea for anyone
dealing with these to take a good look through the code as well
--
Configure bugmail: http://bugs.grommit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
