James Carlson <james.d.carlson at sun.com> writes: > This is a request for a code review on: > > 425 put back #ident lines for things that go back prior to ON migration > http://bugs.grommit.com/show_bug.cgi?id=425 > > The webrev is here: > > http://cr.opensolaris.org/~carlsonj/webrev-425/ > > Note that for some of these items (buffers.py, for example), you'll need > to look at the Wdiffs link to see the changes. The default diffs done > for Cdiffs, Udiffs, and Sdiffs include "-b", which means that fixes to > whitespace (such as converting a space to a tab to correct a #ident > string) are not visible. > > Unlike Rich's previously proposed fix, I did not touch the copyright > year. Fixing or adding a #ident line doesn't count as "significant > change" as usually used for the ON gate copyright rules.
For what it's worth, I touched them because (I thought) we would need to bump them to 2008 pre-integration anyway. Though that's pretty bad reasoning even then, now I think about it a little more. -- Rich
