Nathan Bush writes:
> Proposed fix:
> http://cr.opensolaris.org/~nbush/scm-migration/372/webrev/

1525-1531,1596-1603: nit: indenting seems to get a little strange
around here.

1548-1551: I thought 'cp' preserved modes ... what is this for?

1596-1597: could this be made easier to maintain with awk or some more
capable tools?  This pipe is hard to read.  (It looks to me like it
could even be a single sed expression.)

2719-2721,2738,2742-2743: would be easier to read as a single
expression.

Otherwise, the code looks good.

> Sample execution:
> http://cr.opensolaris.org/~nbush/scm-migration/372/sample/

I like it!

-- 
James Carlson, Solaris Networking              <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677

Reply via email to