Mike Kupfer <mike.kupfer at sun.com> writes:

>>>>>> "Rich" == Richard Lowe <richlowe at richlowe.net> writes:
>
> Rich> However, at present, it outright doesn't work (errors from Hg,
> Rich> because the parent (webrev) isn't a workspace).  
>
> I don't understand.  If you're using -p <path_to_prev_webrev>, it should
> be -p <path_to_prev_snapshot>.

It can be either, dp's reworking of webrev added the ability to create
a webrev relative to another webrev (see webrev(1) INCREMENTAL REVIEWS).

However, that's always had flaws if extra files are added to the file
list between when the prior webrev was taken and now, in the Hg case
with our webrev, it used to "mostly" work, and has since stopped
working at all, because we expect the parent and child to be both
under the control of the same SCM (but don't check such), and
obviously the raw_files/new of the prior webrev is at best not under
SCM control.

-- Rich


Reply via email to