Any reason for
525 sed "/^domain/d" < $(<F).po > $@ ;\
instead of
525 $(SED) "/^domain/d" < $(<F).po > $@ ;\
in Makefile.master? (Other than that the BUILD.po macro is already
similarly deficient...)
Are any of the new .py.po or .pl.po suffix rules exercised during the
current build? Is it appropriate to use $(XGETTEXT) on them, instead of
the script rules that already exist (and should really be similarly
combined) for .sh.po and .ksh.po?
Should the comment on line 995 be updated (to stop enumerating the
suffixes, rather than to augment the enumeration)?
--Mark
On Thu, 27 Mar 2008, James Carlson wrote:
> Date: Thu, 27 Mar 2008 17:36:19 -0400
> From: James Carlson <James.D.Carlson at Sun.COM>
> To: scm-migration-dev at opensolaris.org
> Subject: [scm-migration-dev] common Perl/Python rules code review requested
>
> This is a code review request for:
>
> 6680948 ON could use some common Perl and Python build rules
>
> I ran into one small snag with the cmd/dtrace/demo makefile, but
> things are otherwise quite straightforward. I'm aiming to get this
> into snv_88.
>
> http://cr.opensolaris.org/~carlsonj/webrev-6680948/
>
> I've done full x86 and SPARC builds, and I'm testing now using file
> comparisons of the generated bits.
>
> --
> James Carlson, Solaris Networking <james.d.carlson at sun.com>
> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
> MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
> _______________________________________________
> scm-migration-dev mailing list
> scm-migration-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev
>
On Fri, 28 Mar 2008, James Carlson wrote:
> Date: Fri, 28 Mar 2008 10:39:48 -0400
> From: James Carlson <James.D.Carlson at Sun.COM>
> To: scm-migration-dev at opensolaris.org
> Subject: Re: [scm-migration-dev] common Perl/Python rules code review
> requested
>
> James Carlson writes:
>> I've done full x86 and SPARC builds, and I'm testing now using file
>> comparisons of the generated bits.
>
> I've done diffs of all of the generated Perl and Python files between
> an ON gate build and one with my changed makefiles; no differences
> encountered. I'm all set to file an RTI as soon as I can get a
> review.
>
> The makefiles and the generated targets checked are:
>
> usr/src/cmd/abi/appcert/scripts/Makefile
> abi_index appcert symcheck symprof symreport
> usr/src/cmd/bsmrecord/Makefile
> bsmrecord filter_txt mkmsg
> usr/src/cmd/dtrace/demo/Makefile
> mkdemo
> usr/src/cmd/filebench/fbscript/Makefile
> filebench
> usr/src/cmd/filebench/scripts/Makefile
> filebench_compare fs_flush
> usr/src/cmd/intrd/Makefile
> intrd
> usr/src/cmd/kstat/Makefile
> kstat
> usr/src/cmd/lgrpinfo/Makefile
> lgrpinfo
> usr/src/cmd/projadd/Makefile
> projadd projdel projmod
> usr/src/cmd/psrinfo/Makefile
> psrinfo
> usr/src/cmd/sgs/tools/Makefile
> libconv_mk_report_bufsize
> usr/src/tools/Makefile.targ
> signit codesign_server intf_check mkreadme_osol check_rtime mktpl
> wsdiff hdrchk validate_paths wdiff genoffsets validate_flg cddlchk
> cstyle jstyle ctfcvtptbl
> usr/src/uts/i86pc/cpu/scripts/Makefile
> ao_gendisp
>
>
> --
> James Carlson, Solaris Networking <james.d.carlson at sun.com>
> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
> MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
> _______________________________________________
> scm-migration-dev mailing list
> scm-migration-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev
>
