http://bugs.grommit.com/show_bug.cgi?id=481

           Summary: error handling for source builds is busted
           Product: SCM Migration
           Version: unspecified
          Platform: All
        OS/Version: Solaris 11/Nevada
            Status: NEW
          Severity: normal
          Priority: P3
         Component: nightly
        AssignedTo: scm-migration-dev at opensolaris.org
        ReportedBy: mike.kupfer at sun.com


If you do "nightly -S O" using the SCM Migration nightly(1), you get
this error message in the mail message:

  ==== Creating /home/kupfer/ws/open-build-test-i386/open_src source from
/home/kupfer/ws/open-build-test-i386 (OPEN_SOURCE) ====

  cleaning out /home/kupfer/ws/open-build-test-i386/open_src.
  creating /home/kupfer/ws/open-build-test-i386/open_src.
  1241232 blocks

  Could not copy source tree for open source build.

...even though the build appears to complete okay.

Looking at the code, this error message is generated in
set_up_source_build and in the top-level code, whether or not
copy_source actually failed.

        copy_source $WS $DEST $MAKETARG usr
        echo "\nCould not copy source tree for source build." |
            tee -a $mail_msg_file >> $LOGFILE

I'm not sure that message is actually useful, since copy_source also
generates its own error messages.  If we keep the "Could not copy"
message, it should only be issued if $build_ok is "n".

The copy_source function could do with some additional commenting
about how error returns are handled.


-- 
Configure bugmail: http://bugs.grommit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to