Nathan Bush <nathan.bush at sun.com> writes:

> Hi,
>
> Please review:
> http://cr.opensolaris.org/~nbush/scm-migration/483/webrev/
>
> This change should address all of the following bugs:
> 465 webrev permission display fails for files in workspace root.
> 470 noise in webrev log for deleted files
> 471 "ERROR: set mode of" errors from webrev
> 483 webrev permission display change #372 has poor performance
>

2271/2509: If the filename were of the form /tmp/$$.* this would happen
           anyway (and would be done in a trap that dealt with most
           signals, too).

           Same comment for SEDFILE, though less worthwhile there, I guess.

The logic to actually build HG_PARENT_MANIFEST leaves me wondering if
there's a more obvious way to go about it, but I admit that right now
I can't think of one, and the comment describes what's going on well
enough.

-- Rich

Reply via email to