Dean Roehrich <Dean.Roehrich at sun.com> writes: > On Wed, Apr 23, 2008 at 04:51:40PM -0600, Mark J. Nelson wrote: >> > #356: >> > >> > http://mail.opensolaris.org/pipermail/scm-migration-dev/2008-April/001864.html > > After the recommit, the .hgtags file should not show up in the recommited > cset...rather than stripping .hgtags maybe you ought to just toss it out and > not include it in the recommit?
So, both you and mark say this. But I'm still totally puzzled as to why. My goal with this was that we would stop leaving dangling tags (as you saw), not that we should cover for a user who decided to create tags that will remain valid. That's an entirely separate problem (and one I would leave to the user, given we have no idea of their intent). You guys seem to want to cover for the case where we don't want regular gatelings creating tags in the gate, and thus want to flush anything tag shaped when they reci. I'd like to know why you think that's right (as it molests their data for reasons other than "prevent failure and scary warnings"). So far from this review, I've had that request above, twice. Mark would like (I think?) the "wx reset" equivalent implemented, since he would like the .hgtags reset available as a separate command. Beyond these things, are we happy with the code? I'm trying to get an idea of where we're going with this, so I can get an idea of how long it'll take to get there. -- Rich
