"Mark J. Nelson" <Mark.J.Nelson at Sun.COM> writes: > OK, I somewhat reviewed it. :) > > Why are you unhappy with the changes? They seem more straighforward > than the existing code, and eliminate some bothersome (and obviously > buggy) reimplementation of parenttip identification logic. >
Largely the number of places we may end up having to run hg-active in there. I think there was something else, but that may very well come down to lack of sleep, I'm not seeing it right now. -- Rich > On Sat, 26 Apr 2008, Richard Lowe wrote: > >> Date: Sat, 26 Apr 2008 21:16:13 -0400 >> From: Richard Lowe <richlowe at richlowe.net> >> To: scm-migration-dev at opensolaris.org >> Subject: [scm-migration-dev] Please somewhat review #474 >> >> >> Hey, >> >> There's a webrev at http://cr.opensolaris.org/~richlowe/scm_474 that >> attempts to always use hg-active when finding the parent revision, as >> described in the bug (as also described, Ethan's problem could be >> fixed via less invasive means, but this way should hopefully remove >> the problems we may have with branches in that area). >> >> I've tested it with the slim_install gate at the changesets Ethan >> mentioned, and it works in those cases in the cases) >> >> - No file list specified >> - plain file list without HG_PARENT specified >> - wx filelist without HG_PARENT specified >> - wx filelist with HG_PARENT specified >> - plain filelist with HG_PARENT specified >> >> However, I'm not particularly happy with it, so I'm soliciting >> opinion. If you feel like doing a real code review, that's fine, but >> general comment would be equally appreciated. >> >> Thanks, >> >> -- Rich >> _______________________________________________ >> scm-migration-dev mailing list >> scm-migration-dev at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/scm-migration-dev >>
