Richard Lowe wrote: > Mike Kupfer <mike.kupfer at sun.com> writes: >> * Webrev >> >> These do not appear to be stoppers for SFW: >> >> 374 P3 setting CODEMGR_WS confuses webrev > > I'll look at this soon, if I really have to.
Don't worry, I'm already working on it. >> 372 P3 webrev does not display executable bit change > > It never did for Teamware, which also propagated these. This is P3 why? TeamWare didn't always have the feature to "check in" the file permissions, so most gates (that I've worked on) don't use that feature; that's probably why this never came up with webrev before. I presume this bug was filed now as a corollary to #261, the permissions check module. Since we will be enforcing a policy that the executable bit should never be set, and have other tools that will catch this, it might make sense to lower the priority. But I think this is still a good feature for webrev on it's own and might be useful in other situations. --Nathan
