I took a look at the webrev, and it looks okay. I do have one question about the checks code. The cstyle and jstyle checks have
return os.spawnvp(os.P_WAIT, ...)
which means they can return a negative number. As near as I can tell,
we just propagate that right up the call stack. Is that really the
right thing, or should we intercept negative status values and convert
them to a positive value?
mike
