Hi,Rich and Steve

        I made a change on flg.flp and xref to have them work on mercurial and 
teamware.And I run on a hg workspace and it can work now.

        The slow of find_files I think,it is because the prpath() try to find 
relative path of current directory.It will be endless when condition fit.
           - run flg.flp -r at $CODEMGR_WS,every file found will be the same 
with the one in inc.flg,so,it will take really long time to handle and waste 
time.
                
        The flg.flp -r will take 3+ minutes in my machine in $(SRC)/uts to 
run,and is that normal?And I will research it if needed.Rich,thanks for giving 
me tips earlier days,and would you mind giving your comments?thanks.

         I attach the flg.flp and xref,please make a check of it.And also 
please tell me anything wrong.

Thanks
Jason


----- Original Message -----
From: Richard Lowe <richl...@richlowe.net>
Date: Thursday, April 19, 2007 9:20 am
Subject: Re: xref & flg.flp work about the bug 157
To: Jason Zhao <Jason.Zhao at Sun.COM>
Cc: Stephen Lau <stevel at sun.com>

> Jason Zhao wrote:
> > Hi,Rich
> > 
> > I have seen the bug:http://bugs.grommit.com/show_bug.cgi?id=157
> > 
> > And you commented it was not xref but flg.flp issue.And it can 
> be fixed
> > via "hg locate".
> > 
> > Since I just dipped the project from early beginning,and here I have
> > some questions about it.
> > - Is that problem "flg.flp" could not understand the "hg"?
> 
> Yes, it expects SCCS-like SCCS/s.* files to be present in the tree.
> 
> So when the existing flg.flp is run, it will not show anything 
> matched by a
> find_files (because nothing matches).
> 
> > - I think "hg locate" will return all the files in this project,but
> > flg.flp often print the file by(inc.flg and req.flg) in our
> > teamware.So,to some extent,inc.flg and req.flg will provide users
> > ability to know the files scope,so it is necessary.In my mind,we 
> should> keep inc.flg and req.flg and could just let flg.flp know 
> the "hg"
> > existence and make it print files by inc.flg and 
> req.flg,too.Like this
> > piece of code.
> 
> hg locate can be given an argument to restrict what it shows.
> 
> hg locate 'glob:usr/src/cmd/ssh/**/*.c' for instance.
> 
> Something similar to:
>    hg locate "glob:${dir}/${pat##s.}" | prpath
> 
> in flg.flp.sh's find_files() seems to work, but is very (very) slow.
> 
> -- Rich
> 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xref
URL: 
<http://mail.opensolaris.org/pipermail/scm-migration-dev/attachments/20070421/7df91876/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: flg.flp
URL: 
<http://mail.opensolaris.org/pipermail/scm-migration-dev/attachments/20070421/7df91876/attachment-0001.ksh>

Reply via email to