[qdox-scm] [1257] trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java: decrease lookups for JavaSource.resolveType()

[rfscholte]

Title: [1257] trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java: decrease lookups for JavaSource.resolveType()

Revision

1257

Author

rfscholte

Date

2011-06-01 13:26:37 -0500 (Wed, 01 Jun 2011)

Log Message

decrease lookups for JavaSource.resolveType()

Modified Paths

• trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java

Diff

Modified: trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java (1256 => 1257)

--- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java	2011-06-01 18:18:09 UTC (rev 1256)
+++ trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java	2011-06-01 18:26:37 UTC (rev 1257)
@@ -127,18 +127,22 @@
     	return getCodeBlock();
     }
 
-    /* (non-Javadoc)
+    /*
+     * (non-Javadoc)
      * @see com.thoughtworks.qdox.model.JavaSource#resolveType(java.lang.String)
      */
-    public String resolveType(String typeName) {
-        if (resolvedTypeCache.containsKey(typeName)) {
-            return resolvedTypeCache.get(typeName);
+    public String resolveType( String typeName )
+    {
+        String result = resolvedTypeCache.get( typeName );
+        if ( result == null )
+        {
+            result = resolveTypeInternal( typeName );
+            if ( result != null )
+            {
+                resolvedTypeCache.put( typeName, result );
+            }
         }
-        String resolved = resolveTypeInternal(typeName);
-        if (resolved != null) {
-            resolvedTypeCache.put(typeName, resolved);
-        }
-        return resolved;
+        return result;
     }
     
     /**

---

To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email