- Revision
- 1273
- Author
- rfscholte
- Date
- 2011-07-25 16:37:54 -0500 (Mon, 25 Jul 2011)
Log Message
Use Collections.emptyList() where possible
Modified Paths
- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractBaseJavaEntity.java
- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractBaseMethod.java
- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractJavaEntity.java
Diff
Modified: trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractBaseJavaEntity.java (1272 => 1273)
--- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractBaseJavaEntity.java 2011-07-25 20:47:53 UTC (rev 1272) +++ trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractBaseJavaEntity.java 2011-07-25 21:37:54 UTC (rev 1273) @@ -27,8 +27,8 @@ public abstract class AbstractBaseJavaEntity extends AbstractJavaModel implements Serializable { private List<Annotation> annotations = Collections.emptyList(); - protected String comment; - protected List<DocletTag> tags = new LinkedList<DocletTag>(); + private String comment; + private List<DocletTag> tags = Collections.emptyList(); public AbstractBaseJavaEntity() { super();
Modified: trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractBaseMethod.java (1272 => 1273)
--- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractBaseMethod.java 2011-07-25 20:47:53 UTC (rev 1272) +++ trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractBaseMethod.java 2011-07-25 21:37:54 UTC (rev 1273) @@ -15,7 +15,7 @@ { private List<TypeVariable> typeParameters = Collections.emptyList(); - private List<JavaParameter> parameters = new LinkedList<JavaParameter>(); + private List<JavaParameter> parameters = Collections.emptyList(); private List<Type> exceptions = Collections.emptyList(); private boolean varArgs; private String sourceCode; @@ -52,7 +52,7 @@ public void setParameters( List<JavaParameter> javaParameters ) { - parameters.addAll( javaParameters ); + parameters = javaParameters; this.varArgs = javaParameters.get( javaParameters.size() -1 ).isVarArgs(); }
Modified: trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractJavaEntity.java (1272 => 1273)
--- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractJavaEntity.java 2011-07-25 20:47:53 UTC (rev 1272) +++ trunk/qdox/src/main/java/com/thoughtworks/qdox/model/AbstractJavaEntity.java 2011-07-25 21:37:54 UTC (rev 1273) @@ -20,12 +20,13 @@ */ import java.lang.reflect.Modifier; +import java.util.Collections; import java.util.LinkedList; import java.util.List; public abstract class AbstractJavaEntity extends AbstractBaseJavaEntity implements JavaModel { - private List<String> modifiers = new LinkedList<String>(); + private List<String> modifiers = Collections.emptyList(); private JavaClass parentCls; private String name;
To unsubscribe from this list please visit:
