- Revision
- 1282
- Author
- rfscholte
- Date
- 2011-08-02 15:04:34 -0500 (Tue, 02 Aug 2011)
Log Message
Replace single character Strings with the char where possible
Modified Paths
- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java
- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/JavaConstructor.java
- trunk/qdox/src/main/java/com/thoughtworks/qdox/parser/structs/PackageDef.java
- trunk/qdox/src/main/java/com/thoughtworks/qdox/parser/structs/TagDef.java
Diff
Modified: trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java (1281 => 1282)
--- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java 2011-08-01 20:32:47 UTC (rev 1281) +++ trunk/qdox/src/main/java/com/thoughtworks/qdox/model/DefaultJavaSource.java 2011-08-02 20:04:34 UTC (rev 1282) @@ -136,6 +136,10 @@ return resolveFullyQualifiedName( typeName ); } + /* + * (non-Javadoc) + * @see com.thoughtworks.qdox.model.JavaClassParent#resolveFullyQualifiedName(java.lang.String) + */ public String resolveFullyQualifiedName( String name ) { String result = resolvedTypeCache.get( name ); @@ -150,6 +154,10 @@ return result; } + /* + * (non-Javadoc) + * @see com.thoughtworks.qdox.model.JavaClassParent#resolveCanonicalName(java.lang.String) + */ public String resolveCanonicalName( String name ) { String className = resolveFullyQualifiedName( name ); @@ -211,7 +219,7 @@ // check for class in the same package if (getPackage() != null) { - resolvedName = resolveFullyQualifiedType( getPackageName() + "." + typeName ); + resolvedName = resolveFullyQualifiedType( getPackageName() + '.' + typeName ); if(resolvedName != null) { break lookup; @@ -283,7 +291,7 @@ if (indexOfLastDot >= 0) { String root = typeName.substring(0,indexOfLastDot); String leaf = typeName.substring(indexOfLastDot+1); - String resolvedTypeName = resolveFullyQualifiedType(root + "$" + leaf); + String resolvedTypeName = resolveFullyQualifiedType(root + '$' + leaf); if(resolvedTypeName != null) { return resolvedTypeName; @@ -301,7 +309,7 @@ * @see com.thoughtworks.qdox.model.JavaSource#getClassNamePrefix() */ public String getClassNamePrefix() { - return ( pkg == null ? "" : pkg.getName() + "." ); + return ( pkg == null ? "" : pkg.getName() + '.' ); } public JavaSource getParentSource() {
Modified: trunk/qdox/src/main/java/com/thoughtworks/qdox/model/JavaConstructor.java (1281 => 1282)
--- trunk/qdox/src/main/java/com/thoughtworks/qdox/model/JavaConstructor.java 2011-08-01 20:32:47 UTC (rev 1281) +++ trunk/qdox/src/main/java/com/thoughtworks/qdox/model/JavaConstructor.java 2011-08-02 20:04:34 UTC (rev 1282) @@ -80,6 +80,7 @@ /** * Retrieve the complete codeblock of the constructor, including the sourcecode. + * * @return the code block */ String getCodeBlock(); @@ -98,7 +99,7 @@ * Returns <code>true</code> if this constructor matches the parameterTypes and matches the varArg argument. * * @param parameterTypes - * @param varArgs + * @param varArgs * @return <code>true</code> if signature matches, otherwise <code>false</code> */ boolean signatureMatches( List<Type> parameterTypes, boolean varArgs );
Modified: trunk/qdox/src/main/java/com/thoughtworks/qdox/parser/structs/PackageDef.java (1281 => 1282)
--- trunk/qdox/src/main/java/com/thoughtworks/qdox/parser/structs/PackageDef.java 2011-08-01 20:32:47 UTC (rev 1281) +++ trunk/qdox/src/main/java/com/thoughtworks/qdox/parser/structs/PackageDef.java 2011-08-02 20:04:34 UTC (rev 1282) @@ -21,7 +21,7 @@ public class PackageDef extends LocatedDef { - private String name = ""; + private String name; public PackageDef(String name) { this.name = name;
Modified: trunk/qdox/src/main/java/com/thoughtworks/qdox/parser/structs/TagDef.java (1281 => 1282)
--- trunk/qdox/src/main/java/com/thoughtworks/qdox/parser/structs/TagDef.java 2011-08-01 20:32:47 UTC (rev 1281) +++ trunk/qdox/src/main/java/com/thoughtworks/qdox/parser/structs/TagDef.java 2011-08-02 20:04:34 UTC (rev 1282) @@ -38,6 +38,16 @@ this( name, text, -1 ); } + public String getName() + { + return name; + } + + public String getText() + { + return text; + } + @Override public String toString() { @@ -50,25 +60,4 @@ result.append( getLineNumber() ); return result.toString(); } - - public void setName( String name ) - { - this.name = name; - } - - public String getName() - { - return name; - } - - public void setText( String text ) - { - this.text = text; - } - - public String getText() - { - return text; - } - }
To unsubscribe from this list please visit:
