[waffle-scm] [666] trunk/waffle-core/src/test/java/org/codehaus/waffle/bind/converters: Avoid repeated pattern lookup.

Fri, 02 May 2008 02:10:12 -0700

Title: [waffle-scm] [666] trunk/waffle-core/src/test/java/org/codehaus/waffle/bind/converters: Avoid repeated pattern lookup.
Revision
666
Author
mauro
Date
2008-05-02 04:10:00 -0500 (Fri, 02 May 2008)

Log Message

Avoid repeated pattern lookup.

Modified Paths

Diff

Modified: trunk/waffle-core/src/main/java/org/codehaus/waffle/bind/converters/ListValueConverter.java (665 => 666)

--- trunk/waffle-core/src/main/java/org/codehaus/waffle/bind/converters/ListValueConverter.java	2008-05-01 18:42:47 UTC (rev 665)
+++ trunk/waffle-core/src/main/java/org/codehaus/waffle/bind/converters/ListValueConverter.java	2008-05-02 09:10:00 UTC (rev 666)
@@ -100,8 +100,9 @@
         if (values.size() == 0) {
             return false; // return empty list
         }
+        String numberPattern = patternFor(patterns, NUMBER_PATTERN_KEY, DEFAULT_NUMBER_PATTERN);
         for (String value : values) {
-            if (!matches(value, patternFor(patterns, NUMBER_PATTERN_KEY, DEFAULT_NUMBER_PATTERN))) {
+            if (!matches(value, numberPattern)) {
                 return false;
             }
         }

Modified: trunk/waffle-core/src/test/java/org/codehaus/waffle/bind/converters/ListValueConverterTest.java (665 => 666)

--- trunk/waffle-core/src/test/java/org/codehaus/waffle/bind/converters/ListValueConverterTest.java	2008-05-01 18:42:47 UTC (rev 665)
+++ trunk/waffle-core/src/test/java/org/codehaus/waffle/bind/converters/ListValueConverterTest.java	2008-05-02 09:10:00 UTC (rev 666)
@@ -24,7 +24,7 @@
 public class ListValueConverterTest {
 
     private static final List<Integer> INTEGERS = asList(-1,-2,-3);
-    private static final List<Long> LONGS = asList(1L,2L,3L);
+    private static final List<Long> LONGS = asList(1000L,2000L,3000L);
     private static final List<Double> DOUBLES = asList(0.1d,0.2d,0.3d);
     private static final List<Float> FLOATS = asList(0.1f,0.2f,0.3f);
     private static final List<String> STRINGS = asList("one","two","three");
@@ -52,7 +52,7 @@
         DefaultMessageResources resources = new DefaultMessageResources(configuration);
         ListValueConverter converter = new ListValueConverter(resources);
         assertCanConvertValueToList(converter, INTEGERS, "-1,-2,-3", Integer.class);
-        assertCanConvertValueToList(converter, LONGS, "1,2,3", Long.class);
+        assertCanConvertValueToList(converter, LONGS, "1000,2000,3000", Long.class);
         assertCanConvertValueToList(converter, DOUBLES, "0.1,0.2,0.3", Double.class);
         assertCanConvertValueToList(converter, FLOATS, "0.1,0.2,0.3", Float.class);
         assertCanConvertValueToList(converter, STRINGS, "one,two,three", String.class);

To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email

Reply via email to