On Fri, 2006-12-08 at 11:41 +0100, Gaël de MONNERON wrote:
> Hi all,
>
> Let's present my analysis more clearly:
> (cf http://bugzilla.mkgnu.net/show_bug.cgi?id=890)
>
>
> In original release of ScmBug 0-18-3, in Integration.pm and at the end of
> the get_mailing_list() function, the sender is added by initialized the
> { values }->{ From } variable.
>
> Next, If the email should also appear to have been sent from the SCM user,
> the user is added at a higher priority in the 'From' hash.
All this is correct.
> At least, The 'Reply-To' variable is initialized by $mailing_list->{ >From }
> And that's the point that makes me confused!
>
> Indeed, by logging this variable, I noticed:
>
> 'From' => $VAR1->{'Reply-To'}
>
> (Have a look on the attached logfile.txt)
>
>
>
>
> First thing, you wrote in source code:
>
> if ( $request->{ policies }->{ mail_also_appears_from_scm_user } == ...
>
> instead of :
>
> if ( $request->{ policies }->{mail_on_success}->
> { mail_also_appears_from_scm_user } == ...
This is certainly wrong. I didn't even notice. This part of the patch is
now applied. Thanks!
> Then, in step 2, the problem I noticed at the beginning of my purpose:
> 'From' => $VAR1->{'Reply-To'}
>
>
> Last in step 3,
> if ( $request->{ policies }->{mail_on_success}->{
> mail_also_appears_from_scm_user } == 0) {
> $mailing_list->{ 'Reply-To' }->{ $scm_user_email } = 0;
> }
>
> This instruction changes the 'Reply-To' variable but also the 'From' one.
> Because 'From' variable points on 'Reply-To' variable.
> Do you agree with my analysis?
Yes, your analysis is correct.
> So, is it normal or not?
It was intented to have the 'Reply-To' be the same as the 'From'. But
setting it as a pointer is the wrong thing to do, since the last
statement in Integration.pm:get_mailing_list() essentially modifies both
'From' and 'Reply-To' instead of just 'Reply-To'.
> In my previous patch, I wanted to clearly separate the 'Reply-To' and 'From'
> variable initialization.
Yes, I see that. In essence you make separate copies. I'll apply the
patch. Thanks again for clarifying!
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
