Hey Robert, On Mon, 2007-02-19 at 03:17 -0800, Robert Hudson wrote: > Hi Kristis, > > Thanks for the updated version, I have installed and tested it on my > Windows environment and it seems for work well - thanks.
Oh smashing! > I am seeing this as well: > > Mon Feb 19 10:02:13 2007 10.100.83.101:3745 Processing connection from > dSe > > So and my host isn't on a machine called dSe :-( (And we seem to have > picked up a carriage return). The IP address is the IP address where > the Daemon is running. Whoops. That was intented to be the IP address of the peer host -- the host submitting the request. And "dSe" was supposed to be the address of the peer host. > > Second, I don't understand why this would give us "threading > > issues". It seems that all thread data (even global data) > > would be locally copied: > > > > http://perldoc.perl.org/perlthrtut.html#Shared-And-Unshared-Data > > > This is where my lack of Perl knowledge is showing (This is the first > real work that I have done in Perl). I was comparing it to C++, Java > threading issues - so you are correct there isn't a problem. You've helped a lot more than you can imagine. > You may want to remove the function get_new_bugtracker() from the > Daemon.pm file as it's no-longer used. I'll leave it there. It makes things clearer. > > Does this mean that $request could have remained a global > > variable too ? > > Just want to make sure I understand what's going on. > > In theory I suppose so, however I think that it is better to keep it > local. I can understand the bugtracker being global as it is a > connection to a single bugtracker system. However the request is just > one request, and is unique from the other requests. I also think it > makes it a lot easier to understand as you can see where the request > actually originates in the code. It does. I will leave the request local in there. It's certainly more clear to pass everything around. I'll leave the bugtracker global. > > 4) What's the harm if we do write a pid file for Windows ? > > I don't see any harm in it, however I made it conditional just in case, > as recent comments on the mailing-list mentioned doing some checking to > see if it existed before allowing the Daemon to start. (A UNIX issue, so > I didn't want any chance of it breaking Windows). Ahh, right. Thanks! > I believe the changes that we have made DO fix the multi-message problem > that I was seeing. I used to reliably be able to recreate the problem, > and since the changes can not reproduce it. That's great! > As things stand the version that you E-mailed me (0-19-8) is the version > we will go live with. (Assuming we go live before you release another > one :-)). Go for it. 0.19.8 is the best release so far. _______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
