Hi

I've just tested the actual cvs version.

There has only been a small problem in Mantis.

I've fixed something in Bugzilla cuz i wasn't able to run scmbug without
fixing this.

You find the diff attatched

I'll have a look on assigning to a different user and duplicates now

Kristis Makris([EMAIL PROTECTED])@2007.07.10 12:30:31 -0700:
> Hi Sven, thanks a lot for the patch!! I think we are on a good path.
>
> I applied most of it, but it's been reworked. The reason is that some
> things (like the bug_status_map) are being designed to be common for all
> bugtrackers, not just Mantis. Could you extract from CVS and retest ?
>
> The other issue that needs to be tested/reworked (have not reworked this
> yet) is reassigning bugs to a different user. The new status will still
> be "assigned" but the resolution will be a username (or email address in
> Bugzilla). This needs to be handled in the backend support. Perhaps you
> could have a look at it ? I think the layout of the bug status map
> should be easy to figure out and extend.
>
> We also need to mark some bugs as "duplicates" -- which needs extra
> backend support. Imagine wanting to resolve as a duplicate:
>
> status 547: resolve duplicate 700
>
> We have status=resolve, resolution=duplicate. This needs extra support
> to capture "700" as additional data.
>
> On Tue, 2007-07-10 at 17:43 +0200, Sven Ludwig wrote:
> > Hey Guys,
> >
> > basic functionality for svn / mantis is added.
> >
> > there nearly no checks if the entered status/resolution makes sense
> > (like resolved/open).
> >
> > You find the actual diff (src) attatched.
> >
> > Sven Ludwig
> > _______________________________________________
> > scmbug-users mailing list
> > [email protected]
> > http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users


diff -ur ori/system/src/lib/product/Daemon/Bugzilla.pm.in 
dev/system/src/lib/product/Daemon/Bugzilla.pm.in
--- ori/system/src/lib/product/Daemon/Bugzilla.pm.in    2007-07-10 
21:12:14.000000000 +0200
+++ dev/system/src/lib/product/Daemon/Bugzilla.pm.in    2007-07-11 
12:55:53.000000000 +0200
@@ -1138,7 +1138,7 @@
 
     my $bug_status = $self->integration_get_bug_status( $bugid );
 
-    return $self->resolution_change_check( $bug_status, $proposed_status, 
$proposed_resolution, $bugzilla_bug_status_map ), $bug_status );
+    return $self->resolution_change_check( $bug_status, $proposed_status, 
$proposed_resolution, $bugzilla_bug_status_map );
 }
 
 
diff -ur ori/system/src/lib/product/Daemon/Mantis.pm.in 
dev/system/src/lib/product/Daemon/Mantis.pm.in
--- ori/system/src/lib/product/Daemon/Mantis.pm.in      2007-07-10 
21:25:24.000000000 +0200
+++ dev/system/src/lib/product/Daemon/Mantis.pm.in      2007-07-11 
15:06:06.000000000 +0200
@@ -697,12 +697,12 @@
     my $self = shift;
     my $bugid = shift;
     my $bug_status = $self->integration_get_bug_status( $bugid );
-    
+
     # Verify that the bug is in the assigned state
     if ( $mantis_bug_status_map->{ $bug_status }->{ active } == 1 ) {
-       return (1, mantis_bug_status_tostring( $bug_status ) );
+       return (1, $self->mantis_bug_status_tostring( $bug_status ) );
     } else {
-       return (0, mantis_bug_status_tostring( $bug_status ) );
+       return (0, $self->mantis_bug_status_tostring( $bug_status ) );
     }
 }
 
diff -ur ori/system/src/lib/product/Daemon/TestDirector.pm.in 
dev/system/src/lib/product/Daemon/TestDirector.pm.in
--- ori/system/src/lib/product/Daemon/TestDirector.pm.in        2007-07-10 
21:12:14.000000000 +0200
+++ dev/system/src/lib/product/Daemon/TestDirector.pm.in        2007-07-11 
13:00:32.000000000 +0200
@@ -117,6 +117,17 @@
 }
 
 
+sub tdc_bug_status_map {
+    my $self = shift;
+    my $data = shift;
+
+    if ( $data ) {
+       $self->{ tdc_bug_status_map } = $data;
+    } else {
+       return $self->{ tdc_bug_status_map };
+    }
+}
+
 
 sub tdc_bug_comment_tag {
     my $self = shift;
@@ -472,7 +483,7 @@
 
     my $bug_status = $self->integration_get_bug_status( $bugid );
 
-    return $self->resolution_change_check( $bug_status, $proposed_status, 
$proposed_resolution, $tdc_bug_status_map ), $bug_status;
+    return $self->resolution_change_check( $bug_status, $proposed_status, 
$proposed_resolution, $self->tdc_bug_status_map );
 }
 
 
@@ -483,7 +494,7 @@
     my $self = shift;
     my ( $bug_status_string ) = ( @_ );
 
-    return $self->valid_resolution_states_list( $bug_status_string, 
$tdc_bug_status_map );
+    return $self->valid_resolution_states_list( $bug_status_string, 
$self->tdc_bug_status_map );
 }
 
 
@@ -494,7 +505,7 @@
     my $self = shift;
     my ( $bug_status_string ) = ( @_ );
 
-    return $self->valid_resolutions_list( $bug_status_string, 
$tdc_bug_status_map );
+    return $self->valid_resolutions_list( $bug_status_string, 
$self->tdc_bug_status_map );
 }
 
 

Attachment: pgpec5SdFZMH8.pgp
Description: PGP signature

_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to