OK, I reverted the change.

Why do I have this suspicion that your change in Bugtracker.pm might
have... broken automatic status resolution for everyone ? Including
Robert with TestDirector. I was pretty sure that the Mantis.pm.in file
was calling the Bugtracker.pm interface with the wrong parameters...


On Tue, 2007-10-16 at 22:06 +0200, Gonzalo Pérez Eguizabal wrote:
> Sorry, i'm spanish and my English is a little bit poor. I think there
> is a mistake wirh the Mantis.pm.in patch. When I told you that "I
> didn't patch Mantis.pm.in file.", I wanted to tell you that the code
> of Mantis.pm.in was OK (without the patch that you upload to the
> list). You should go back to the previous version of Mantis.pm.in
> (1.42).
> 
> Sorry, and thanks for your great job. Thanks again!
> 
> Gonzalo Pérez Eguizabal
> 
> On 10/16/07, Kristis Makris <[EMAIL PROTECTED]> wrote:
> > This is probably the change I was asking someone to test and report back
> > for success. Applied. Thanks!
> >
> > http://bugzilla.mkgnu.net/show_bug.cgi?id=1050#c10
> >
> > On Tue, 2007-10-16 at 17:08 +0200, Gonzalo Pérez Eguizabal wrote:
> > > I'm also trying to integrate Subversion and Mantis (1.0.3) with Scmbug. I
> > > have had the same problems. With the next code I have been able to commit
> > > status changes to Mantis.
> > >
> > > Patch:
> > >
> > > Index: Bugtracker.pm.in
> > > ===================================================================
> > > RCS file:
> > > /projects/scmbug/cvsroot/system/src/lib/product/Daemon/Bugtracker.pm.in,v
> > > retrieving revision 1.27
> > > diff -u -r1.27 Bugtracker.pm.in
> > > --- Bugtracker.pm.in  1 Oct 2007 23:00:10 -0000       1.27
> > > +++ Bugtracker.pm.in  16 Oct 2007 14:42:05 -0000
> > > @@ -400,7 +400,7 @@
> > >
> > >      # Verify the status change
> > >      foreach my $possible_resolution_state ( @{ $bug_status_map->{
> > > $current_bug_status }->{ possible_resolution_states } } ) {
> > > -     if ( $possible_resolution_state eq $proposed_status ) {
> > > +     if ( $possible_resolution_state eq $bug_status_map->{
> > > $proposed_status }->{ name } ) {
> > >           # The status change is valid.
> > >           $status_change_is_valid = 1;
> > >       }
> > >
> > > Gonzalo Pérez Eguizabal
> > >
> > > P.D: I didn't patch Mantis.pm.in file.
> > >
> > >
> > >
> > > diff -u -r1.41 Mantis.pm.in
> > > --- src/lib/product/Daemon/Mantis.pm.in 17 Sep 2007 04:16:09 -0000
> > > 1.41
> > > +++ src/lib/product/Daemon/Mantis.pm.in 2 Oct 2007 22:29:02 -0000
> > > @@ -531,7 +531,7 @@
> > >
> > >      my $bug_status = $self->integration_get_bug_status( $bugid );
> > >
> > > -    return ( $self->resolution_change_check(
> > > $bug_status,
> > > $self->mantis_bug_status_tokey( $proposed_status ),
> > > $proposed_resolution,
> > > $mantis_bug_status_map ),
> > > $self->mantis_bug_status_tostring( $bug_status )
> > > );
> > > +    return( $self->resolution_change_check(
> > > $self->mantis_bug_status_tostring( $bug_status ),
> > > $proposed_status ,
> > > $proposed_resolution,
> > > $mantis_bug_status_map ),
> > > $self->mantis_bug_status_tostring( $bug_status ) );
> > >  }
> > >
> >
> >

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to